ext/intl: trying out ideas for GH-19362 #19429
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we re not implementing zend for C++ really here, just seeing how creating objects with zend mm allocator would play out with ICU.
devnexen
force-pushed
the
intl_use_abit_zmm
branch
from
62a4844 to
2567ae7
Compare
|
I think it's on purpose that just limited set of C++ is used in that extension and we should not divert from it IMO. In fact we should try to convert as much as we can to C and use C API where possible. So -1 on this. |
|
If I decide to pursue it, it will probably need a RFC and will be for post 8.5 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we re not implementing zend mm for C++ really here, just seeing how creating objects with zend mm allocator would play out with ICU.